Ask Your Question
0

why start heka container twice?

asked 2016-09-21 11:00:51 -0500

mmmark gravatar image

Hi,
At kolla 2.0.2
ansible/roles/common/tasks/bootstap.yml

- name: Starting heka bootstrap container
  kolla_docker:
    action: "start_container"
    common_options: "{{ docker_common_options }}"
    detach: False
    environment:
      KOLLA_BOOTSTRAP:
      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
    image: "{{ heka_image_full }}"
    labels:
      BOOTSTRAP:
    name: "bootstrap_heka"
    restart_policy: "never"
    volumes:
      - "{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro"
      - "/etc/localtime:/etc/localtime:ro"
      - "kolla_logs:/var/log/kolla/"
  when: kolla_logs_volume.changed

ansible/roles/common/tasks/start.yml

- name: Starting heka container
  kolla_docker:
    action: "start_container"
    common_options: "{{ docker_common_options }}"
    environment:
      KOLLA_CONFIG_STRATEGY: "{{ config_strategy }}"
      SKIP_LOG_SETUP: "true"
    image: "{{ heka_image_full }}"
    name: "heka"
    volumes:
      - "{{ node_config_directory }}/heka/:{{ container_config_directory }}/:ro"
      - "/etc/localtime:/etc/localtime:ro"
      - "kolla_logs:/var/log/kolla/"
      - "heka:/var/cache/hekad"
      - "heka_socket:/var/lib/kolla/heka/"

I think that bootstrap_heka is useless.

edit retag flag offensive close merge delete

1 answer

Sort by ยป oldest newest most voted
0

answered 2016-09-25 19:47:04 -0500

updated 2016-09-25 19:47:57 -0500

This is the part of code that gets executed differently in a bootstrap situation:

# Bootstrap and exit if KOLLA_BOOTSTRAP variable is set. This catches all cases
# of the KOLLA_BOOTSTRAP variable being set, including empty.
if [[ "${!KOLLA_BOOTSTRAP[@]}" ]]; then
    exit 0
fi

As you can see its not doing anything useful. A bug report or review change would be welcomed to fix this issue.

Regards -steve

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Get to know Ask OpenStack

Resources for moderators

Question Tools

Stats

Asked: 2016-09-21 10:51:01 -0500

Seen: 140 times

Last updated: Sep 25 '16