How to send a patch set to other author's commit?

asked 2015-04-05 05:06:35 -0500

pshige gravatar image

I'd like to send a patch set to another author's commit for co-authoring. But I don't know how.

I don't know much about git.

I've ever sent patch sets and updated my own commits. But I've never sent any patch set to other author's commit in http://review.openstack.org .

Thank you in advance.

edit retag flag offensive close merge delete

1 answer

Sort by ยป oldest newest most voted
3

answered 2015-04-05 14:15:27 -0500

smaffulli gravatar image

If understand your question correctly, you'll have to fetch the patchset you want to edit and submit it for review.

 $ git review -d #####

will fetch the latest patch in the changeset number #### from review.openstack.org in your local repository. You'll then be able to follow the normal workflow for updating a change.

edit flag offensive delete link more

Comments

Thank you! I will try.

The normal workflow you mentioned is "Adding a Dependency" http://docs.openstack.org/infra/manual/developers.html#adding-a-dependency? (http://docs.openstack.org/infra/manua...)

pshige gravatar imagepshige ( 2015-04-05 18:35:55 -0500 )edit

Not adding a dependency, but updating a change (the one smaffulli linked in his answer). The critical part is that you need to make sure you use --amend when you commit so that you update the current commit rather than adding a new commit.

fungi gravatar imagefungi ( 2015-04-06 08:08:37 -0500 )edit

Get to know Ask OpenStack

Resources for moderators

Question Tools

1 follower

Stats

Asked: 2015-04-05 05:06:35 -0500

Seen: 591 times

Last updated: Apr 05 '15