Ask Your Question
1

How long should I wait before nudging people to review a changeset?

asked 2014-08-05 18:22:20 -0500

anonymous user

Anonymous

I submitted a change for review a long time ago and the patch still hasn't merged. I am not sure how long I should wait before asking people to review. How long should I wait and who/how should I ask for reviewers?

edit retag flag offensive close merge delete

2 answers

Sort by ยป oldest newest most voted
1

answered 2014-08-07 07:07:43 -0500

divius gravatar image

It depends on a project a lot. Some projects have shorter review queues, some have longer. You can ask on IRC, but please don't be too annoying as well. Generally core folks see your patch on their Gerrit dashboards.

I can give some advice as an Ironic core reviewer:

  1. Make CI pass on your patch. Recheck if you believe that CI is wrong.
  2. Make up a clear commit title and message for your patch. It will attract attention from reviewers and help them with understanding, why they need your change in the project.
  3. Get some votes from non-core folks as well. Under time pressure core prefer patches that already got positive feedback from at least someone.
  4. Obviously sort out -1's from even non-core folks. Again, under time pressure core will skip anything that has -1.
  5. If you believe your patch is important for the whole project, don't hesistate to propose it during Open Discussion section of the weekly meeting.
  6. Keep in mind deadlines: we're approaching them right now and core folks tend to have more and more critical things to do.
  7. Done all this, appear on IRC channel with your patch. Find time when the most of the folks are online (should be US time I guess).

Good luck!

edit flag offensive delete link more
0

answered 2014-08-06 01:24:23 -0500

kevinbenton gravatar image

I would start by adding a few project core members to the review immediately after uploading the patch. This will at least get the patch into their review queue so they should eventually get to it as they go through reviews.

Make sure that the patch is getting a good verification from Jenkins before you expect to see any reviews. Many reviewers will just completely ignore patches that fail to pass the OpenStack CI tests.

If you still don't receive an initial review after several days, start asking around in the IRC channel for reviews but try not to directly ask an individual IRC user unless he/she previously reviewed your patch.

Do not ask for reviews on the dev mailing list. Everyone will ignore it except for the people annoyed enough by the message to reply back to tell you to never do that. Some projects have hundreds of patch updates per day. If everyone sent a review request to the list asking for reviews, it would be mass chaos.

edit flag offensive delete link more

Comments

I wouldn't recommend adding core members to a review as soon as one uploads a patch. Core members already know to keep an eye on the incoming reviews queue and doing this only results in additional unneeded emails, in addition to making it more difficult for them to notice and be responsive when a patch they did review gets updated.

jpichon gravatar imagejpichon ( 2014-08-08 05:09:13 -0500 )edit

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Get to know Ask OpenStack

Resources for moderators

Question Tools

1 follower

Stats

Asked: 2014-08-05 18:22:20 -0500

Seen: 331 times

Last updated: Aug 05 '14