Ask Your Question
0

driver.init_host() moved in abstract NetworkManager, is this a regression?

asked 2011-02-11 11:44:34 -0500

salvatore-orlando gravatar image

The call to driver.init_host() has been moved to the generic NetworkManager class in a recent merge (I believe rev658). This implies the init_host() routine in linux_net which sets up forwarding and natting with iptables is invoked even for the Flat network model, where this setup is not required.

Not sure whether this is a regression bug or a desired behaviour.

edit retag flag offensive close merge delete

7 answers

Sort by ยป oldest newest most voted
0

answered 2011-02-22 17:41:55 -0500

vishvananda gravatar image

If you have time, please go ahead and make a bug and a branch to propose.

Vish

On Feb 22, 2011, at 7:26 AM, Salvatore Orlando wrote:

Question #144979 on OpenStack Compute (nova) changed: https://answers.launchpad.net/nova/+q...

Status: Answered => Open

Salvatore Orlando is still having a problem: Hi Vish,

I think the approach you are proposing should solve the issue. Shall I raise a bug for that and assign it to you? Alternatively, I can take care of that.

Salvatore


You received this question notification because you are a member of Nova Core, which is an answer contact for OpenStack Compute (nova).

edit flag offensive delete link more
0

answered 2011-02-22 15:26:08 -0500

salvatore-orlando gravatar image

Hi Vish,

I think the approach you are proposing should solve the issue. Shall I raise a bug for that and assign it to you? Alternatively, I can take care of that.

Salvatore

edit flag offensive delete link more
0

answered 2011-02-11 18:41:50 -0500

What is NetworkManager, if not a base class for all network managers?

edit flag offensive delete link more
0

answered 2011-02-11 18:35:00 -0500

vishvananda gravatar image

hmm, good point. This probably shouldn't happen in flat mode. I'm guessing floating ips will fail in flat mode anyway because the source natting will not work, so perhaps the solution is to make FlatManager not inherit from the NetworkManager at all.

edit flag offensive delete link more
0

answered 2011-02-11 18:53:14 -0500

vishvananda gravatar image

The code for floating ips is currently shared between FlatDHCPManager and VlanManager, so it is in the base class. There is some shared code between the various classes, so removing FlatManager from the hierarchy is probably a bad idea. Perhaps we overload __init__ in FlatManager to not call super.__init__, and we raise NotImplemented() for the floating ip commands for now? These can be implemented at some future date if someone figures out how to make floating ips work properly in flat mode.

Vish

On Feb 11, 2011, at 10:48 AM, Salvatore Orlando wrote:

Question #144979 on OpenStack Compute (nova) changed: https://answers.launchpad.net/nova/+q...

Status: Needs information => Open

Salvatore Orlando gave more information on the question: Is there a use case for supporting floating IPs in all network managers? If yes, we should probably keep the call to driver.init_host in the base class, and then somehow fix SNAT in flat mode. Otherwise, I reckon it would be better to move driver.init_host in VlanManager; but there is still value in having FlatManager inheriting from NetworkManager


You received this question notification because you are a member of Nova Core, which is an answer contact for OpenStack Compute (nova).

edit flag offensive delete link more
0

answered 2011-02-11 18:48:16 -0500

salvatore-orlando gravatar image

Is there a use case for supporting floating IPs in all network managers? If yes, we should probably keep the call to driver.init_host in the base class, and then somehow fix SNAT in flat mode. Otherwise, I reckon it would be better to move driver.init_host in VlanManager; but there is still value in having FlatManager inheriting from NetworkManager

edit flag offensive delete link more
0

answered 2011-02-22 18:00:05 -0500

salvatore-orlando gravatar image

Sure Vish!

I'll do that ASAP.

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Get to know Ask OpenStack

Resources for moderators

Question Tools

1 follower

Stats

Asked: 2011-02-11 11:44:34 -0500

Seen: 21 times

Last updated: Feb 22 '11