Ask Your Question
0

Which pep8 version for Quantum?

asked 2011-08-31 10:47:37 -0600

salvatore-orlando gravatar image

Our pip-requires states: pep8 >= 0.5.0

We should probably remove the ">=" and focus on a specific pep8 version. For instance, Quantum code base, which is clean for pep8 0.5.0, has errors for pep8 0.6.1

Other openstack projects currently use:

  • nova: 0.6.1
  • glance: 0.5.0
  • swift: 0.5.0
  • keystone: 0.5.0

Any opinion?

edit retag flag offensive close merge delete

4 answers

Sort by ยป oldest newest most voted
0

answered 2011-09-06 01:57:59 -0600

danwent gravatar image

damn... when you reply to a question via email it automatically sets the status to answered....

edit flag offensive delete link more
0

answered 2011-09-06 01:21:22 -0600

danwent gravatar image

I agree with focusing on only a single version.

The issue with nova requiring 0.6.1 instead of 0.5.0 bit me a while back, but it seems that even fairly recent distros ship only with 0.5.0 . Generally speaking, I think nova is the best project to mirror.

It seems like it would be really easy for the run_tests.sh script to run "pep8 --version" and confirm that it is equal to "0.6.1" and if not, tell the user to install pip and run "pip install pep8==0.6.1".

Dan

On Wed, Aug 31, 2011 at 3:50 AM, Salvatore Orlando < question169676@answers.launchpad.net > wrote:

New question #169676 on quantum: https://answers.launchpad.net/quantum/+question/169676 (https://answers.launchpad.net/quantum...)

Our pip-requires states: pep8 >= 0.5.0

We should probably remove the ">=" and focus on a specific pep8 version. For instance, Quantum code base, which is clean for pep8 0.5.0, has errors for pep8 0.6.1

Other openstack projects currently use:

  • nova: 0.6.1
  • glance: 0.5.0
  • swift: 0.5.0
  • keystone: 0.5.0

Any opinion?


You received this question notification because you are an answer contact for quantum.


~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. http://www.nicira.com | http://www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~

edit flag offensive delete link more
0

answered 2011-09-06 08:54:16 -0600

salvatore-orlando gravatar image

And that's fine. The status should be answered, because you answered it! That means that there is an answer to the question, not that the problem is solved (only who submits the question can set the status to 'solved').

I realized launchpad states are somewhat misleading, especially for native english speakers!

On the pep8 issue, I agree with your answer. We can check the pep8 version before running tests and warn the user that Quantum is compliant with pep8 0.6.1 and it is therefore important to install that version. We can then ask Joe/Monty to update pep8 on the build slave where Quantum runs.

edit flag offensive delete link more
0

answered 2011-09-06 18:29:39 -0600

danwent gravatar image

On Tue, Sep 6, 2011 at 1:55 AM, Salvatore Orlando < question169676@answers.launchpad.net > wrote:

Question #169676 on quantum changed: https://answers.launchpad.net/quantum/+question/169676 (https://answers.launchpad.net/quantum...)

Status: Open => Solved

Salvatore Orlando confirmed that the question is solved: And that's fine. The status should be answered, because you answered it! That means that there is an answer to the question, not that the problem is solved (only who submits the question can set the status to 'solved').

ah.... the wonderful world of launchpad :)

>

I realized launchpad states are somewhat misleading, especially for native english speakers!

On the pep8 issue, I agree with your answer. We can check the pep8 version before running tests and warn the user that Quantum is compliant with pep8 0.6.1 and it is therefore important to install that version. We can then ask Joe/Monty to update pep8 on the build slave where Quantum runs.

Sounds good. thanks.

>


You received this question notification because you are an answer contact for quantum.


~~~~~~~~~~~~~~~~~~~~~~~~~~~ Dan Wendlandt Nicira Networks, Inc. http://www.nicira.com | http://www.openvswitch.org Sr. Product Manager cell: 650-906-2650 ~~~~~~~~~~~~~~~~~~~~~~~~~~~

edit flag offensive delete link more

Your Answer

Please start posting anonymously - your entry will be published after you log in or create a new account.

Add Answer

Get to know Ask OpenStack

Resources for moderators

Question Tools

1 follower

Stats

Asked: 2011-08-31 10:47:37 -0600

Seen: 37 times

Last updated: Sep 06 '11