Ask Your Question

Revision history [back]

Just finished testing my patch , it works fine. Am I supposed to submit patch to upstream ?
No more git revert 9d06520645f28d96ef905a709f8ff0c27842b58b. Just add one line of code to vifs.py.

Just finished testing my patch , it works fine. Am I supposed to submit patch to upstream ?
No more git revert 9d06520645f28d96ef905a709f8ff0c27842b58b. Just add one line of code to vifs.py.

--- a/nova-docker/novadocker/virt/docker/vifs.py        2015-03-07 17:32:24.118070981 +0300
+++ b/nova-docker/novadocker/virt/docker/vifs.py        2015-03-07 17:35:36.698098732 +0300
@@ -248,6 +248,8 @@
                           run_as_root=True)
             utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'addr',
                           'add', ip, 'dev', if_remote_name, run_as_root=True)
+            utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'link',
+                          'set', if_remote_name,'up',run_as_root=True)
             if gateway is not None:
                 utils.execute('ip', 'netns', 'exec', container_id,
                               'ip', 'route', 'replace', 'default', 'via',

Just finished testing my patch , it works fine. Am I supposed to submit patch to upstream ?
No more git revert 9d06520645f28d96ef905a709f8ff0c27842b58b. Just add one line of code to vifs.py.

diff --git a/novadocker/virt/docker/vifs.py b/novadocker/virt/docker/vifs.py
index a2e7b23..1d159f7 100644
--- a/nova-docker/novadocker/virt/docker/vifs.py        2015-03-07 17:32:24.118070981 +0300
a/novadocker/virt/docker/vifs.py
+++ b/nova-docker/novadocker/virt/docker/vifs.py        2015-03-07 17:35:36.698098732 +0300
b/novadocker/virt/docker/vifs.py
@@ -248,6 +248,8 @@
@@ class DockerGenericVIFDriver(object):
                           run_as_root=True)
             utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'addr',
                           'add', ip, 'dev', if_remote_name, run_as_root=True)
+            utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'link',
+                          'set', if_remote_name,'up',run_as_root=True)
             if gateway is not None:
                 utils.execute('ip', 'netns', 'exec', container_id,
                               'ip', 'route', 'replace', 'default', 'via',
 

UPDATE as of 03/11/2015
Patch merged upstream
https://review.openstack.org/#/c/163022/
https://git.openstack.org/cgit/stackforge/nova-docker/
END UPDATE

Just finished testing my patch , it works fine. Am I supposed to submit patch to upstream ?
No more git revert 9d06520645f28d96ef905a709f8ff0c27842b58b. Just add one line of code to vifs.py.

diff --git a/novadocker/virt/docker/vifs.py b/novadocker/virt/docker/vifs.py
index a2e7b23..1d159f7 100644
--- a/novadocker/virt/docker/vifs.py
+++ b/novadocker/virt/docker/vifs.py
@@ -248,6 +248,8 @@ class DockerGenericVIFDriver(object):
                           run_as_root=True)
             utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'addr',
                           'add', ip, 'dev', if_remote_name, run_as_root=True)
+            utils.execute('ip', 'netns', 'exec', container_id, 'ip', 'link',
+                          'set', if_remote_name,'up',run_as_root=True)
             if gateway is not None:
                 utils.execute('ip', 'netns', 'exec', container_id,
                               'ip', 'route', 'replace', 'default', 'via',